David B

Results 8 comments of David B

The SQL query is generated by the function `get_report_sql()` here: https://github.com/mailwatch/MailWatch/blob/1.2/mailscanner/quarantine_report.inc.php#L165 The query is: ``` SELECT DISTINCT a.id AS id, DATE_FORMAT(timestamp,'%%d/%%m/%%y %%H:%%i:%%s') AS datetime, a.timestamp AS timestamp, a.to_address AS to_address,...

I think the solution is to change the SQL query to use `GROUP BY` instead of `SELECT DISTINCT`. I couldn't think why `DISTINCT` was used, maybe someone was being extra...

Here are a few other related things to fix: * Put a try-catch block around calls to dbquery(), to catch any exceptions thrown by SQL. * Fix discrepancy, where user...

Yes you could also use the existing "loading" class. That's ok with me. I was worried that maybe some users preferred the existing behaviour, and such a change would alter...

No worries, I updated the PR #355 and the test: http://jsfiddle.net/zehu9vge/

I also found that the default size of a video in an iFrame is 300 x 150. In PR #353 I added some example code to the Readme that shows...

I was under the impression that VTKExamples was a separate project to VTK (and the examples included with that codebase). This might suggest a different set of guidelines about coding...

Thanks for the feedback. Do you want any of the suggestions in this PR or should I squash it?