Daniel Widdis
Daniel Widdis
No deadline. It's a nice-to-have. Next release code freeze is about 6 weeks away but if you don't make that... not an issue!
As far as testing, the method you're changing is already covered by tests, so either it will fail, or it will pass but include an unneeded mock of an index...
Hey Jamie, thanks for the update! > `testFailedUpdateTemplateInGlobalContextNotExisting FAILED` error. This is probably a test depending on the old behavior that you just removed as I implied [in this comment](https://github.com/opensearch-project/flow-framework/issues/678#issuecomment-2089364530)....
> The documentation states 11 is sufficient but 14 is required for the full suite of tests: Don't worry about any JDK other than 11, 17, or 21. We use...
> copy that into a similar test method which tests the new behavior you added One other note, we do measure test coverage; codecov will make a comment on a...
> `testFailedUpdateTemplateInGlobalContextNotExisting FAILED` error. One other helpful hint. You can see the logged error message in your output: ``` 1> [2024-05-07T19:44:02,236][INFO ][o.o.f.i.FlowFrameworkIndicesHandlerTests] [testFailedUpdateTemplateInGlobalContext] before test 1> [2024-05-07T19:44:02,605][ERROR][o.o.f.i.FlowFrameworkIndicesHandler] [testFailedUpdateTemplateInGlobalContext] Failed to...
Hey @JamieBort hope you're doing well and making good progress. @joshpalis is working on implementing #717 which is using the same "PUT" update API that was assumed when writing this...
This was effectively addressed during #980
Hey @ajay83 go for it!
> @dbwiddis can you kindly elaborate more about point 3 , as per point 3 getInputs currently returns List.copyOf(inputs) and this should be class field as NAME? same for the...