Daniel Widdis

Results 429 comments of Daniel Widdis

Waiting on: - [x] https://github.com/opensearch-project/ml-commons/pull/2449

> Implement steps for external REST APIs (similar to ML Connectors but more general/non-ML) Moving this step in the backlog to 2.13.0 to support https://github.com/opensearch-project/observability/issues/1805

While attempting to write REST integration tests for this, it was a challenge as the REST request returned successfully while the state deletion was still processing. I'm leaning heavily toward...

Given the potential for "fine grained provisioining" in the future, it seems the "alternative you have considered" is the best option. Allow a parameter like "deprovision=true" to fully or partially...

> Is this a feature or bug-fix? More of a feature as there's not really a bug. Provisioning a workflow that doesn't create resources is somewhat of an edge case....

This relates to #339 implemented in #340 where I combined the register + deploy steps. This would be really nice to include.

Still waiting on: - [x] opensearch-project/ml-commons#2293

Upstream is merged. Tests are passing except for the ones on macos-latest due to lack of arm64 support. We could change the actions to macos-13, or just accept the failures.

Hey @JamieBort welcome! Not sure if you have permission to assign to yourself, but I'm assigning it to you! Let me know if you have any questions.

> Does it matter what branch name I use? Nope, we use a triangle workflow (you can google that) but basically: 1. you will fork this repository to your own...