Dirkjan Bussink

Results 33 comments of Dirkjan Bussink

> Did I not write the test properly? There was a bug in the test that I fixed up, so it should be green now.

@sidorares Any feedback on this change?

> @sidorares Any feedback on this change? @sidorares Any update on this one?

> > @sidorares Any feedback on this change? > > @sidorares Any update on this one? @sidorares Any updates on this one?

The error message looks like somehow an explicit cancel on the context was triggered. It doesn't look like an expiry. And these contexts are not really something the server even...

> @dbussink `EndBackup` seems not called That would indicate that we also don't want on the background goroutine that uploads. Which means that request completes and the context is cancelled....

> Looks like you haven't signed the commit. I would like to include this in latest release so let me fix that. Ah, I think maybe that's new since this...

@serathius Rebased and added the signature!

> Needs backporting to 18.0 and 19.0, presumably? Caused by #15192? This is not related to those changes and I don't think we need to backport here.

> This PR adds implementation of [`ELT`](https://dev.mysql.com/doc/refman/8.0/en/string-functions.html#function_elt) func in evalengine. Given, `FIELD` is the complement function of this one, should we add both in one go?