release: build with consistent paths

[dbussink]

This changes the builds to always add -trimpath which removes specific build time paths from the binary (like current directories etc).

Improves build reproducability to make the final binary independent from the specific build path.

Lastly, when stripping debug symbols, also add -w to strip DWARF symbols as well which aren't needed in that case either.

Found this when doing #13545 and thought that maybe these additional changes would also be welcome.

[dbussink]

Is this something that there's any interest in?

[dbussink]

I have rebased this branch since there were conflicts with main.

[codecov-commenter]

Codecov Report

Merging #13552 (4b41f74) into main (4b41f74) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 4b41f74 differs from pull request most recent head 830afdb. Consider uploading reports for the commit 830afdb to get more accurate results

@@           Coverage Diff           @@
##             main   #13552   +/-   ##
=======================================
  Coverage   75.17%   75.17%           
=======================================
  Files         452      452           
  Lines       36770    36770           
=======================================
  Hits        27643    27643           
  Misses       7393     7393           
  Partials     1734     1734           

Flag	Coverage Δ
all	75.17% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4b41f74...830afdb. Read the comment docs.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.

[dbussink]

I have rebased this branch since there were conflicts with main.

Have done this again, is there interest in this or should I close it?

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.

[dbussink]

Have done this again, is there interest in this or should I close it?

I have updated again, but still have the same question :smile:.

[serathius]

Thanks for your resilience, sorry that the PR got lost.

Looks like you haven't signed the commit. I would like to include this in latest release so let me fix that.

[dbussink]

Looks like you haven't signed the commit. I would like to include this in latest release so let me fix that.

Ah, I think maybe that's new since this originally was opened? I can update the PR here and do that.

[serathius]

@dbussink Would be great if you add a signoff like https://github.com/etcd-io/etcd/pull/14815/commits/bd6b4350c55f43dee1483f745eb7a9d8837376ff

Just add Signed-off-by: Dirkjan Bussink <[email protected]> to end of commit message.

[dbussink]

@serathius Rebased and added the signature!