Daniel Bünzli

Results 878 comments of Daniel Bünzli

I'm no longer sure exactly why. Some type error messages may be a bit less unwidely if you proceed that way but it might not be a good reason to...

> I think colons are invalid in segments of Windows paths Not entirely, the incredible Windows® path (see this [very useful document](https://docs.racket-lang.org/reference/windowspaths.html)) allows them if you start your path with...

> This means that they can have sizes that are negative in the x or y dimension. Operations on boxes with negative size are undefined. This is indicated in the...

Indeed I can repeat that in the module somewhere. As far as this question is concerned. > Should all Box2 functions be made to support negative sizes? I suspect it...

Also functions that extend boxes by their side (better names to be found): ```ocaml let rebox_minx minx r = Box2.of_pts (V2.v minx (Box2.miny r)) (Box2.max r) let rebox_maxx maxx r...

Also review the `Invalid_arg` on empty boxes. It's unclear whether it was a good to have a distinguished element. Try to make the operations total (and/or allow them to specify...

> Also review the `Invalid_arg` on empty boxes. It's unclear whether it was a good to have a distinguished element. Try to make the operations total (and/or allow them to...

This is not really surprising as the gamut of linear `sRGB` (i.e. the space of `Gg.color` values) is much smaller than that of `L*C*h`. This was written a long time...

> It would be nice if users shouldn't be concerned with out-of-gamut colors during a roundtrip, Sure but hacks for nicing floating point inaccuracies tend to lead to slippery slopes....

I added a warning to the docs. It would still be nice to see if we can do something about round trips.