Daniel Bünzli

Results 878 comments of Daniel Bünzli

> Actually, example 2 was just made up and I would have only needed it for writing to /sys recently. Note that I guess example1 could be solved by `stat`ing...

Isn't the problem here that you are using `Pervasives.print_string` in test.ml ? I guess this is what does the translation. I just checked and the `OS.Cmd` combinators only use `Unix.openfile`...

In fact you are using `OS.File.read` with `OS.File.dash` which in this case will not use `open_in_bin` but simply use `Pervasives.stdin`. So I guess this is the actual source of the...

> (and for versions of OCaml (< 4.08 likely) We should make sure a fix gets in `4.07`. Currently `bos` has no C bindings and tends to be not so...

Even call that `copy` for a surprise.

Daniel this is really needed, I'm constantly running into it.

I think the code in this [gist](https://gist.github.com/dbuenzli/ff42499522fec449ddfcad656cf95cbe) could make an improvement over the current convoluted [code](https://github.com/dbuenzli/bos/blob/97b0093541fcebb0179077d365f5bf04442aa072/src/bos_os_path.ml#L78-L147). It should have the reliability @dsheets wanted. It will delete everything in the directory...

An unscientific benchmark on a large directory indicates that this technique is a bit slower: ``` > find $(odig cache path) | wc -l 28664 > time rm -r $(odig...

Also it may be worth introducing an error handling mecanism in the vein of the folding functions.

Not necessarily against it. But * Any performance regression on element creation ? I guess not but sometimes js compilation can be surprising. * Are there many use cases beyond...