David Buchmann

Results 944 comments of David Buchmann

i guess in version 2, the tricky bit is here: https://github.com/KnpLabs/KnpMenu/blob/master/src/Knp/Menu/Resources/views/knp_menu.html.twig#L78 or https://github.com/KnpLabs/KnpMenu/blob/master/src/Knp/Menu/Resources/views/knp_menu.html.twig#L5 @Jbekker @GeertDD is one of you up to write a pull request to fix this?

hm, tricky question. so indeed, that bin is in both jackalope versions (and not needed at all as jackalope commands are integrated into the symfony console). from an application point...

> you can also require |jackalope/jackalope| which provides > |phpcr/phpcr-implementation| and in turn requires > |jackalope/jackalope-transport| which the DBAL and jackrabbit transports > implement i don't think requiring jackalope/jackalope would...

sounds reasonable to me, to increase consistency and reduce the risk of debugging changing how the application works. i guess these will be guidelines and then we apply them to...

agreed, i like the proposal and @Nyholm input. lets have plugins_before and plugins_after. that was the first question i asked myself looking at the example: how do we control the...

the query string is indeed relevant. imagine some old style php cms that does `index.php?page=abc`... i am a bit confused though: does $redirectRequest->getUri() not include the query string? according to...

client-common does not provide a PSR 7 implementation. can you please check what PSR-7 implementation you are using? that typically would be guzzlehttp/psr7 or nyholm/psr7, but could be a bunch...

i just tried and i think there is some problem with your flow: ```

request->getUri returns a PSR-7 uri, thats why i checked that. we seem to not have a test for the redirect plugin. can you try to reproduce the problem with a...

i think that there must be some more redirect going on that makes the plugin see a loop, as the query string is part of the request. it probably is...