Daniel Simon

Results 14 comments of Daniel Simon

Looks like it stems from [`3rdparty/find_dependencies.cmake:100`](https://github.com/isl-org/Open3D/blame/0a5785548dcab381e62d8a088e3f911d0d98f0f7/3rdparty/find_dependencies.cmake#L100). @stotko Git says you put the comment on the previous line in, can you explain what that changes and comment was fixing? I haven't...

Ok, Ive been playing with it a bit and I am starting to understand. When qhull is fetched with ExternalProject it is not downloaded until build time, so when we...

@ssheorey How can I run the CI pipeline locally to verify my fix?

Hmmm, Looks like the ubuntu-wheel build is failing because c-cache is out of space? Not sure what to do about that.

Ok, I ran my tests in my development environment. Guess I should use the docker containers to replicate the CI environment and figure out those tests.

Hi @ssheorey this PR likely wont fix that issue as I haven't yet changed how the TBB dependency is being accessed. This is likely also why @errissa is facing issues...

I agree that setting the version requirement for TBB should be part of this PR. Based on the ubuntu failure in CI, its the `collaborative_call_once` header that is missing. The...

Looks like the minimum version requirement for `collaborative_call_once.h` is v2021.4.0. Now it looks like we aren't putting version requirements in the find package scripts in `3rdparty/find_dependencies.cmake`, this means that error's...

Actually the suggested resolution runs into problems when dealing with the third party includes. Now those should be addressed by linking to the interface library target created by each library's...

I'm wondering if I am using this correctly. I tried applying this to a mesh that I then applied quadric simplification to and the render didn't come out making sense....