Dan Bowling

@straker I had to spread the params of `get()` to account for the possibility of an `undefined` default value. This does change the way the cache behaves a bit though--any...

Although passing `undefined` and passing nothing are equivalent when reading the value directly, they are not equivalent in this PR because of the arg spreading, which can determine the difference...

The following files in `lib` use `cache.set()`, but I elected not to include them in the refactor - `lib/core/utils/get-flattened-tree.js` - only sets new values and does not use return -...

I converted this PR back to draft while I work through the expanded scope of updating `lib` to use the default value poperty.

Stephen, that gets back to what Wilco put in https://github.com/dequelabs/axe-core/issues/3276. Your example `thing = cache.get('thing') || defaultValue` is close, but would need to also set the default value to the...

Yes, that and a CI/local test discrepancy is why I took this back to draft status. If we want to change the intended behavior, thats okay too. Cache is a...

@straker or @WilcoFiers - how would you like me to handle the current failed tests for places where the [creator is returning undefined and throwing an error](https://circleci.com/gh/dequelabs/axe-core/48476?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)? If we want...

The [reply to my last comment can be found here](https://github.com/dequelabs/axe-core/pull/3608#discussion_r966448810). Since the `assert` is throwing for `is-modal-open`, we also decided that a better solution than treating that as a bug...

Quick update on where this issue is at: POC exists using Husky to trigger but the shell script needs refactoring to use portable shell commands, rather than test logic that...

@WilcoFiers `aria.getRole()` replaced the custom logic as part of PR #3582. I introduced two new tests to cover this case there since it was changing anyway: - [Integration](https://github.com/dequelabs/axe-core/pull/3582/files#diff-1bcc001009df0404cb3be6a5307da75b0a033c1666f29bae9bd8eabaf6a27a5fR133) - [Unit](https://github.com/dequelabs/axe-core/pull/3582/files#diff-ee05efa4ef695f44f20c76819bf4bd12be53d428e53cfff7ec8433d1574b3722R47)