Dušan Borovčanin

Results 102 comments of Dušan Borovčanin
trafficstars

Add missing tests to SDK and increase SDK test coverage. You can check which functions are missing tests by running: ``` go test -timeout 30s -coverprofile=cover.out github.com/absmach/magistrala/pkg/sdk/go go tool cover...

The proposed idea is good, but let's use default protocol ports for adapters (8000, 1883, 5683...).

We changed the approach to access control and we'll soon integrate a new solution with corresponding docs. Closing due to irrelevance.

Since we're not able to reproduce this one with other tools, and due to inactivity, I'm closing it.

This works for me. It's a good idea to keep error handling in the "upper" layer anyways (i.e. handle repo error in svc, and svc in API, just like we...

As for the `handleError` location, I'd keep it unexported and per-service for the time being. If there is a lot of overlapping, we can consider making it the `internal` package.

This looks like we need to `Unwrap` and replace the whole error with the wrapper in the API layer.

This might make the most sense for protocol adapters so that we can easily enable raw messages or packet dumps for debugging purposes.

Closing this one as a duplicate of #2103.