magistrala
magistrala copied to clipboard
MF-1506 - Move Groups back to domain services
Signed-off-by: dusanb94 [email protected]
What does this do?
This pull request makes domain services (Users and Things) use the internal Groups package for entity groups manipulation.
Which issue(s) does this PR fix/relate to?
This pull request resolves #1512, resolves #1513, and closes #1506, closes #649.
List any changes that modify/break current functionality
Groups are moved to domain services, which changes internal architecture when it comes to entity groups, also moving the corresponding API to the respective services.
Have you included tests for your changes?
Yes.
Did you document any new/modified functionality?
Yes.
Notes
N/A
Codecov Report
Merging #1517 (c381caa) into policies (4e142d1) will increase coverage by
0.02%
. The diff coverage is38.91%
.
@@ Coverage Diff @@
## policies #1517 +/- ##
============================================
+ Coverage 64.79% 64.82% +0.02%
============================================
Files 136 136
Lines 11352 11348 -4
============================================
Hits 7356 7356
+ Misses 3397 3393 -4
Partials 599 599
Impacted Files | Coverage Δ | |
---|---|---|
auth/api/http/groups/endpoint.go | 0.00% <0.00%> (ø) |
|
auth/api/http/groups/requests.go | 0.00% <0.00%> (ø) |
|
auth/api/http/groups/transport.go | 0.00% <0.00%> (ø) |
|
internal/groups/api/requests.go | 7.40% <0.00%> (ø) |
|
things/api/things/http/transport.go | 85.30% <0.00%> (ø) |
|
users/postgres/users.go | 53.88% <ø> (ø) |
|
users/service.go | 63.97% <ø> (ø) |
|
internal/groups/api/transport.go | 45.37% <28.57%> (+0.41%) |
:arrow_up: |
auth/postgres/groups.go | 64.08% <42.52%> (ø) |
|
internal/groups/api/endpoint.go | 8.48% <46.15%> (ø) |
|
... and 3 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 4e142d1...c381caa. Read the comment docs.
We changed the approach to access control and we'll soon integrate a new solution with corresponding docs. Closing due to irrelevance.