Darren Bolduc
Darren Bolduc
When the time comes, we should also see if we can get it to run successfully instead of expecting errors https://github.com/googleapis/google-cloud-cpp/blob/20b1a940c80318f8e9cec6b6a5010c5178779bd6/google/cloud/gkeconnect/CMakeLists.txt#L29-L40
/gcbrun
@svrnm nothing has happened. I am not sure `@open-telemetry/cpp-approvers` is a thing.
For the record, we do not *need* to refactor. We can "delete" the `storage::oauth2` classes by moving them into `storage_internal` and keeping the implementation mostly the same. We might do...
quick thoughts for whoever picks this up: `AutoPopulated` should *technically* be a method annotation, not a field annotation. (although in practice, I bet there is no difference, because they only...
https://cloud.google.com/iam/docs/reference/rest/v1/organizations.roles/delete#query-parameters This makes me think gapic-showcase is wrong.
We should still clean this up, but it is not a bug in our code. Blocked externally on: https://github.com/googleapis/gapic-showcase/issues/1593
There is a way to do this. https://doc.rust-lang.org/cargo/reference/unstable.html#public-dependency ...but only in the nightly build. https://github.com/rust-lang/rust/issues/44663. I do not think it is ready for primetime. --- Eventually, it would be nice...
Another approach would be to enumerate the types we use in our public APIs: https://github.com/awslabs/cargo-check-external-types tonic does this: https://github.com/hyperium/tonic/blob/master/tonic/Cargo.toml#L112-L136
If these fields are not included in the body, then they are not currently sent over the wire. We have to include them as query parameters. Luckily, the `google.api.http` proto...