Dan Nicholson

Results 168 comments of Dan Nicholson

At Endless we use libsoup in ostree and I don't think we'd switch over to libcurl without a lot of testing. Even though I don't have any reasons to doubt...

Can you split out the GUri change? It seems useful on its own and a necessary prerequisite for the rest of the work. After that, is there any reason soup3...

I personally think you should leave the soup2 code entirely alone. That ensures there are no regressions introduced and removing the backend later is simpler. At that point any duplication...

IMO, let's start with testing + explicit `--with-soup3`. I'm less familiar the FCOS parts of the CI, but that might be workable, too.

@q66 Are you planning on picking this up again? Need help with it?

> High level looks sane at a brief glance, but there's lots of details here. (One I have is how this intersects with worker threads we create internally) Yeah, I...

Oh, well I only added actual locking in `fsck`. The rest of the stuff in `src/ostree` is just turning the `--lock-timeout` option into a call to `ostree_repo_set_lock_timeout()`, which could be...

@cgwalters Had another thought about the threads. * If the lock to be taken is shared, only do it when outside a transaction. Assuming that the transaction is started on...

OK, I added a bunch of fixups that I'll squash soon, but I wanted to give a chance to see the intermediate state if anyone was interested. I believe I...

Yeah, I'll rebase later today. Some of the commits should be reordered a bit.