Dan Nicholson

Results 168 comments of Dan Nicholson

Apologies if anyone was reviewing this. I restarted after the above discussion and force pushed over the previous series.

Ugh, you're right. I added a test where the parent is partial and the grandparent is normal, but it's entirely common that you don't have the parent at all. I'm...

Another thing that might help is a flag or option that says not to update the ref. So you can fetch the commit to your repo but not update your...

@alexlarsson did you see my comment at https://github.com/flatpak/flatpak/pull/3413#discussion_r379012706?

> Ahh that's a tricky corner case. It's not at all obvious that doing a commit-only pull only would negatively affect static deltas. I guess a reflog would have been...

> We could probably extend the "partial" state to be: > > * not partial > * partial metadata > * partial content > > The "use object fetch" path...

Here's another rework that includes looking for matching commit bindings as a fallback if the history search is unsuccessful. The added tests indicate it's doing the right thing, but I'm...

The dirty idea I had was to change `ostree admin finalize-staged` so it opens `/boot` (and `/sysroot`) when starting and then blocks waiting for `SIGTERM` via `sigwait`. This would effectively...

Alright, I'll put something together. One question I had is, what if someone unstages the deployment? Should it watch `/run/ostree/staged-deployment` for deletion and stop itself without finalizing? I think finalizing...