Dan Nicholson

Results 168 comments of Dan Nicholson

Should I just override the failure? It's in a part of code that I didn't touch and I don't know how to get different versions of `clang-format` to agree on...

> Yeah, this has bit us at least twice in the past I believe. It's so messy...even if we pick just one target we force everyone to use that specific...

There's certainly no harm in this, but I'm fairly positive that the tests require `bash`. When I look over [`libtest.sh`](https://github.com/ostreedev/ostree/blob/main/tests/libtest.sh) and [`libtest-core.sh`](https://github.com/ostreedev/ostree/blob/main/tests/kolainst/data-shared/libtest-core.sh), it mostly looks POSIX compliant to me. However,...

> There's certainly no harm in this, but I'm fairly positive that the tests require `bash`. When I look over [`libtest.sh`](https://github.com/ostreedev/ostree/blob/main/tests/libtest.sh) and [`libtest-core.sh`](https://github.com/ostreedev/ostree/blob/main/tests/kolainst/data-shared/libtest-core.sh), it mostly looks POSIX compliant to me....

> > > to > > > ``` > > > bindatafiles="bash yes ostree" > > > ``` > > > > > > > > > > > >...

> Bash is generally compatible with POSIX sh (+/- how it is handled loops body which in case of `ostree` is as well not relevant) so is if someone will...

Interesting. Can you tell exactly where in flatpak this starts to fail? Flatpak does some interesting things with temporary and parent/child repos that might not get good test coverage in...

The error comes from [GZlibDecompressor](https://gitlab.gnome.org/GNOME/glib/-/blob/main/gio/gzlibdecompressor.c#L365). Why that would happen from creating the file in the repo's `tmp` directory rather than in `/var/tmp`... I don't know. @cgwalters any ideas? It would...

> the only difference that is obvious is that one uses the dfd and a relative path while the other just uses whatever is in $TMPDIR or /var/tmp. Exactly. Do...

BTW, the 2 errors are essentially the same thing. In one you're getting a `.file` object, which is zlib compressed. Eventually `GZlibDecompressor` returns `G_IO_ERROR_PARTIAL_INPUT` with the message set as "Need...