Daniel (dB.) Doubrovkine

Results 3341 comments of Daniel (dB.) Doubrovkine

@Kukunin bumping myself on top of your list!

> hi @dblock. do you mean that it'd be good to finalize and get this PR merged? If yes, then it's something I can do Yes, please! Rebase & al....

The problem is that it's going through a formatter. Before we figure out how to shortcut Grape in this case, I bet you can solve this by just doing `status...

I've renamed this to "Support aborting requests via a Rack::Response.finish`, and labeled this as a feature. I am not sure we want this, but it's a valid thing.

> This is still an issue. Route params with `type: 'String'` revert to `type: 'Integer'` inside mounted APIs. Give a shot at fixing it?

I wonder whether `GrapeEntityCoercer` belongs in `grape-entity`. And if there's anything we can move out there from here further?

> @keithpitty @dblock I would pretend that `Grape::Entity` is a custom type which implements [the parse method](https://github.com/ruby-grape/grape#custom-types-and-coercions), thus, Grape won't know anything about Grape entity. I guess it is a...

Grape uses dry-types but is not too opinionated about coercion otherwise - what I am saying is that we're not trying to force everyone to convert a spec (eg. grape-entity)...