Daniel (dB.) Doubrovkine

Results 3341 comments of Daniel (dB.) Doubrovkine

I don't think you need swagger UI, but see CONTRIBUTING in this project for how to contribute in general If you do want actual swagger UI, the way I do...

> Regarding adding **spec** for this case, should I just go on and create a new pull request and this spec in a new file?. I want to contribute to...

Try to turn this into a spec?

This does look like a bug, or something that maybe we can address in a backward compatible way, appreciate a PR.

You can set headers with [header](https://github.com/ruby-grape/grape#response), so `header X, nil` will remove it, same as in Rails. See https://github.com/ruby-grape/grape/blob/master/lib/grape/endpoint.rb#L273 where headers are returned to the rack middleware stack. That said,...

I think half of the problem is that Grape namespaces != grape-swagger namespaces. Grape-swagger just magically believes that the first part of the path is a namespace. Throw in versioning...

With `strict: true` you're getting a 406 without the proper `Accept-Version` header, so when it comes to Swagger you probably get the effect of that routing. I could be wrong,...

This is correct, however I think we'd welcome a feature that evaluates the endpoint condition based on the request.

That's not good. You got a project up that reproduces this? Or bisect it to a change?

If this fixes that feels like `grape_logging` should be doing a `require 'grape'`. Open an issue in that repo.