Daniel (dB.) Doubrovkine
Daniel (dB.) Doubrovkine
> Renaming a class or namespace is a break, I would stick to `Ml` as previous. Do client users have to reference this namespace explicitly, meaning why is it considered...
One of the tests failed because `closeCursor` was renamed. ``` Note: Using configuration file /home/runner/work/opensearch-php/opensearch-php/phpstan.neon.dist. Error: Call to an undefined method OpenSearch\Namespaces\SqlNamespace::closeCursor(). ------ ---------------------------------------------------- Line tests/Namespaces/SqlNamespaceTest.php ------ ---------------------------------------------------- 83 Call...
@shyim Take a look at this change and comments re: backwards-compatibility from @saimedhi above. Does this work for you or do we need to do something else with this PR?
@saimedhi one more, in https://github.com/opensearch-project/opensearch-php/pull/213/files#diff-1e5c4748694dfd5e04e32ebaaaaf36245262522d929e9d9232d8afc2c32352b3L41 the API spec was changed to un-confuse metric and node_id. What's the best way to restore this behavior inside `getUri`?
> > @saimedhi one more, in https://github.com/opensearch-project/opensearch-php/pull/213/files#diff-1e5c4748694dfd5e04e32ebaaaaf36245262522d929e9d9232d8afc2c32352b3L41 the API spec was changed to un-confuse metric and node_id. What's the best way to restore this behavior inside `getUri`? > > @dblock,...
I extracted the SQL backwards-compatibility fixes from here into https://github.com/opensearch-project/opensearch-php/pull/222, once that's merged the cron will reset this PR and all tests should pass. @shyim @saimedhi
Want to rebase and finish this @petardz? [Catch All Triage - [1](https://github.com/dblock), [2](https://github.com/reta), [3](https://github.com/krisfreedain), [4](https://github.com/OVI3D0)]
What shall we do with this @petardz? Close? Finish? [Catch All Triage - [1](https://github.com/dblock), [2](https://github.com/reta), [3](https://github.com/krisfreedain), [4](https://github.com/OVI3D0)]
Rebase?
LGTM, see why integ tests failed?