Daniel (dB.) Doubrovkine
Daniel (dB.) Doubrovkine
> @dblock Sorry, I'm not sure I follow. Are you saying I still don't have it quite right? 1. The test is in the right place now, but `tests/default/user_behavior_insights/initialize.yaml` should...
> Hi team... Curious if this could be reviewed and merged? Please iterate to green first? Happy to review when all tests are passing.
Very nice. I'd start building up UPGRADING.md like we have in https://github.com/opensearch-project/opensearch-py/blob/main/UPGRADING.md to note all the backwards incompatible changes.
We went with https://github.com/opensearch-project/opensearch-php/pull/233 which introduced PSR interfaces. Could use some help testing and fixing anything broken before we do a release.
Yes, we should replace it. Appreciate a PR! Please make sure not to look at any non-APLv2-compatible code.
The last release was from 2022 so I am going to say it's unlikely :(
@kimpepper Yes. There's an unfinished PR for this in https://github.com/opensearch-project/opensearch-php/pull/228, but alternate implementations are welcome.
The Psr implementation has been merged and will be released as part of 2.4.0 (#244), please give it a try before we release! See [UPGRADING](https://github.com/opensearch-project/opensearch-php/blob/main/UPGRADING.md) for details and https://github.com/dblock/opensearch-php-client-demo/pull/1 for...
[Catch All Triage - [1](https://github.com/dblock), [2](https://github.com/krisfreedain), [3](https://github.com/amistrn)]
@saimedhi There's another change in the spec that you might need to handle, similar to https://github.com/opensearch-project/opensearch-py/pull/777, see https://github.com/opensearch-project/opensearch-api-specification/pull/416 where `node_id_or_metric` should not be added as a parameter, but the individual...