Dan Bjorge comments

Results 87 comments of


                                            Dan Bjorge

List rule generates false positive when role attribute present

I agree with @straker that this failure represents a real accessibility issue, so it's probably good/intended for the `list` rule to give a violation here. However, I also agree that...

chore: merge master into develop

Careful; the "update branch" button will do a thing you don't want

Preserve legal comments from third party dependencies

Updating to a more recent esbuild would also enable us to use `esbuild-plugin-license` to automate the production of `LICENSE-3RD-PARTY.txt`. I used something like this to validate #4304: ```js // /build/tasks/esbuild.js...

Update developer guide require node version

It requires at least node 18 as of #4320

Incorrect reporting of target size violation from incorrect offset calculation

See related https://github.com/dequelabs/axe-core/issues/4194 (same root cause manifesting as one part of a different issue)

aria-valid-attr-value rule too strict on aria-controls / aria-owns

I agree with all of the "pass" and "fail" results, and I agree with incomplete for the case of the selected tab with a missing `aria-controls` value. I begrudgingly agree...

Scrolling content with iframe that has focusable content should not fail `scrollable-region-focusable`

Verified the example on stable chrome, firefox, safari

Decorative images should be ignored by the region rule

We received a new +1 of this issue in a customer support ticket today

Filter partial results based on resultTypes

> If incomplete is turned off by resultTypes then I think all reviewOnFail rules should be disabled. There's no reason to run those if incomplete results are just going to...

ad-hoc visualization state becomes inconsistent after toggling extension off and on

If we do end up closing due to the timebox, we should update our release validation steps accordingly, since validating that this doesn't happen is an explicit part of step...