Dan Bjorge

Results 87 comments of Dan Bjorge

One more point we'll need to deal with: Per https://bugzilla.mozilla.org/show_bug.cgi?id=1444294 , Firefox doesn't support the `browser.permissions.onAdded`/`onRemoved` events we're about to start using for Chrome, so we'll need some sort of...

I apologize; I didn't mean to signal that we're working on this issue. I'm just keeping notes about what we'd want to consider were we to reopen this issue in...

A few more implementation notes: * Firefox 77 (currently in beta, release date slated for 6/2/20) will start supporting the `onAdded`/`onRemoved` permissions events (yay!) * As of 77, Firefox's `windows.create()`...

@kewisch Thanks for the update! We're actually the case where we pass `focused: true`, but I see that the same bug covers our case as well. Looking forward to the...

Thanks Fer! To summarize from earlier comments, the known work that we'd love to see community contributions for includes (but isn't limited to): * [ ] Update `file://` URL handling...

@ferBonnin Yes, this is technically feasible (iirc, the title bar already has custom behavior/styling between the 2 platforms)

This is interesting to think about! I'm not sure it would make sense for us to do this for all tests (most of the tests don't have exactly the same...

Yes, the repro I included in the description still reproduces the issue with `@octokit/[email protected]`.

:+1:, if a user specifies positional values against an options class with no [Value] members and IgnoreUnknownArguments = false, I'd expect it to be an error.

Just an update on this: our team is currently working with Deque and with the author of https://github.com/IsaacWalker/PlaywrightAxeDotnet to migrate that library to be the basis of a new, officially...