David Bieber
David Bieber
Thanks for the PR! If I understand correctly, `mock` as a package from pypi continues to work in Python 3, and this change just allows us to drop the dependency...
Hi @bfelbo, Are you suggesting that the help show: ``` fury.py --verbosity=VERBOSITY ``` or is there a command that's actually _missing_ from the help, that you'd like it to show?...
Agreed this is an issue. Let me explain why the current behavior is as it is, and how we can probably fix it. ## Current State ### "--help" vs "--...
Actually, perhaps it's even better to just show the methods of a class in that class's help screen, even if the class hasn't been instantiated yet. We'll just need to...
The help text is generated at: https://github.com/google/python-fire/blob/1ac5105a0437518785033f47dd78746678e5133a/fire/helptext.py#L47 The list of possible actions (including commands) is generated by https://github.com/google/python-fire/blob/1ac5105a0437518785033f47dd78746678e5133a/fire/helptext.py#L61 The commands are aggregated at: https://github.com/google/python-fire/blob/1ac5105a0437518785033f47dd78746678e5133a/fire/helptext.py#L330-L331 And `isCommand` is defined at: https://github.com/google/python-fire/blob/1ac5105a0437518785033f47dd78746678e5133a/fire/value_types.py#L35-L36...
Here's a minimal example that would need to be fixed to resolve this: ``` In [1]: class A: ...: def x(self): ...: return 0 ...: In [5]: import fire In...
The code ignoring methods in classes is here: https://github.com/google/python-fire/blob/1ac5105a0437518785033f47dd78746678e5133a/fire/completion.py#L331-L334 Simply changing that from False to True will result in methods being included in the help. Additional changes will likely also...
Could you provide an example? If fire is providing help which is inaccurate and giving the user commands to run that don't work because of case mismatches, that would be...
Thanks for your contribution. I'll post back here once I've had a chance to look in more detail. For now, I notice the [travis checks](https://travis-ci.org/google/python-fire/builds/314378598?utm_source=github_status&utm_medium=notification) are failing for Python 2.7,...
I'm not aware of such a project. It's a cool idea -- any ideas how a project like that might work?