David Bieber comments

Results 202 comments of


                                            David Bieber

Raising FireError in init is not handled properly

@joejoevictor is also taking a look at this

default values should be visible in help screen

Yeah, good idea, let's make a new issue to track that. We might end up fixing them together though.

default values should be visible in help screen

Thanks! Looks great

default values should be visible in help screen

Glad you found it :) If you have further questions, don't hesitate to ask.

default values should be visible in help screen

> https://github.com/google/python-fire/issues/184#issuecomment-619430755: "from looking at the code I'm seeing..." Awesome summary. Your assessment of the coding style is spot on. The redundant parentheses is a mistake on our part though,...

formatting_windows.initialize_or_disable breaks ansi escape codes

Thanks for the feedback. We (the developers of fire) aren't active Windows users, and we're certainly open to changing this behavior.

Simple implementation of allowing externally defined formatters

FYI objects that defines a custom \_\_str\_\_ method are now serialized using that custom \_\_str\_\_ method.

Fix #229, #293: Modify parser.py to re-insert quotes correctly

Thank you for the PR! I will let you know once I have looked through it more closely. You mentioned in our discussion on #229 that you had some test...

Fix #229, #293: Modify parser.py to re-insert quotes correctly

Hello again. Thanks for adding the tests!

Logging messages don't using logging

We'd like to fix this such that for the typical user (who doesn't configure any logging settings), the behavior is the same as it currently is, with the INFO logs...