David Bieber comments

Results 204 comments of


                                            David Bieber

ci: expand build matrix for major OS

> @dbieber if I won't need approval for each run, it would be great (faster) It should run without approval now. 👍

Optional type args are mistyped in help

Thanks for reporting this. Looks like a bug to me. Next steps are to add a test case and identify and resolve the issue.

replaced sum of strings for fstrings

These changes are included in https://github.com/google/python-fire/pull/551

bug fix for help from typing package, add test for optional and union

Thanks for putting this together! At a quick glance, this LGTM. One comment inline above.

bug fix for help from typing package, add test for optional and union

I only just enabled CI for pull requests so this didn't surface earlier -- it looks like there are some test failures.

lint: configure pre-commit with Ruff

Ah, we might actually need all the "# pylint: " directives for the google-internal fire codebase. Let's hold off on this.

bugs when use pytorch

Could you provide the code for defining the resnet50 object in resnet_runner.py?

Visualziations of the python-fire codebase

Thanks for offering, but I don't plan on incorporating these diagrams at this time.

--help not working with classes

> TypeError: Inspector.__init__() missing 1 required keyword-only argument: 'theme_name' This should be fixed in v0.7.1 👍. Thanks for reporting.

Tuple of strings parsed as string if one of the strings contains a hyphen

Thanks for reporting; this is indeed a confusing experience. As you've discovered, you can get the behavior you want with `python example.py '("foo-bar","baz")'`, but as you note, it is not...