David Bieber

👍 Here's an example: ```python def make_function_maker_handler_event(function_maker_handler_event_factory): """This is a Google-style docstring with long args. Args: function_maker_handler_event_factory: The function-maker-handler event factory responsible for making the function-maker-handler event. Use this whenever...

Merry Christmas indeed! > how would we want to handle it? I haven't been able to think of a perfect solution. More thoughts below: > I was thinking we could...

Yes, Google style uses 80 character as the max line length. Fire's goal is to work well with any Python software though (within reason), so I'd be inclined to do...

> The first word of line2 can easily fit in line1 so it would think that line1 is intentionally short. This check would need to take place before removing the...

First, I think the heuristic might warrant a slight addition: If the arg length (measured by the position of the ":") is more than 50% of the "apparent max line...

Ah, might have spoke too soon about where to define the state. Looks like the state for Google-style args is actually defined here, not with the rest of the parser...

> Please review PR #476. Took a skim and left two comments. Will come back to it later.

> if we take the above example, the line length is 81 so rounding up to 90 would make the arg_length (39) not meet our criteria of arg_length being longer...

Merged https://github.com/google/python-fire/pull/440 (🔲 going forward we will want to change the naming though / possibly reintroduce w/ the guard as you suggest)

Noted! It's been a while since we've had updates or a release. I think I can likely make time to do one before the end of the year.