David Bieber comments

Results 204 comments of


                                            David Bieber

Brainstorm potential Fire CLI configurations

Possible entry points for configs: - fire.Fire's **kwargs - fire.Fire(name='example') - Flags - `example -- --verbose` - Decorators - @fire.decorators.SetParseFn(str)

Brainstorm potential Fire CLI configurations

#220 requests the ability to exclude certain objects from Fire's help, e.g. imported modules, and local variables. This could be accomplished through fire.Fire(excludes=[fire, logging]) or fire.Fire(commands_only=True). (Same as #47, or...

Brainstorm potential Fire CLI configurations

https://github.com/google/python-fire/issues/231 suggests being able to disable the printed output for use cases where the developer wants to do something with the returned component from Fire.

Brainstorm potential Fire CLI configurations

Adding to the list the ability to configure the order functions are displayed in the help screens https://github.com/google/python-fire/issues/298 PR: https://github.com/google/python-fire/pull/310

adding code to support optional type abbreviation request

Thanks for the contribution! This looks good. What Python versions does this support?

adding code to support optional type abbreviation request

We don't need the improvement to apply to Python 2, but we do need to make sure we don't break fire for Python 2.7.

Output of the example for grouping in docs is wrong

Thanks for noticing the discrepancy. How about if we make Pipeline.run return a list [ingestion_output, digestion_output]. Then the stage outputs will be displayed on consecutive lines as in the guide's...

*varargs cannot tell the difference between whitespaces within and out of quotes

Thanks for opening the issue. Could you please provide a simple example?

mis-assigned keyword arguments when two function parameters have the same name

Yes, you can work on this.

Typo improvement for using CLI

You're all set; it's merged.