Dave Berenbaum
Dave Berenbaum
Do we need to specify if there is any particular syntax that is not supported? For example, in the current PR, I don't think https://hydra.cc/docs/advanced/override_grammar/basic/#modifying-the-defaults-list is applicable (although it probably...
Leaving high-level product thoughts here instead of https://github.com/iterative/dvc/pull/8067. Overall, it looks great as a first step. Seems more flexible and stable than what we have now. My only additional concern...
> Do you think it's worth adding an explicit note in the ref (I was avoiding including info that we will end up extracting to user guide)? We could add...
Looks good @daavoo! Can you resolve the merge conflict and do one more iteration? I think we could merge as is, but since there is no rush here, let's try...
@jorgeorpinel Do you want to take a final pass at this or not?
@alex000kim Maybe you want to review this one? Note that this is only for part 1 of the Hydra integration, which only includes https://github.com/iterative/dvc/pull/8067, not https://github.com/iterative/dvc/pull/8093.
@dtrifiro Do you think it's realistic to get this drafted, reviewed, and merged this sprint?
In case @jorgeorpinel didn't already mention it, please open future docs PRs from this repo instead of a fork. That way, the changes will be deployed into an example app...
@jorgeorpinel I merged, but feel free to leave comments if you have them
@flippedcoder Do you mind separating these whenever you have a chance? We try to be pretty strict about keeping issues logically separate so that one part of an issue doesn't...