Dave Bartolomeo

Results 13 comments of Dave Bartolomeo

Note to reviewers: The actual implementation of the join order metric probably doesn't need a very thorough review, since it's just a slightly reorganized version of the existing DCA code....

I believe that I've addressed or responded to all feedback. Should be ready for re-review.

For compiled languages, presumably you would just run the autobuilder, or perhaps let the user specify the build command to run. If the user already has a VSCode "Task" set...

If the TypeScript output is no longer being bundled, I assume that the bundled extension winds up using `ts-loader` or something like that to handle the TypeScript at runtime? How...

>There is no difference in how the files are loaded in development or production, both will load just a single extension.js file. Great, this is what I was hoping for.

This is expected in the current design. However, I see how this is confusing, so let's discuss how we could change this. I'll give some background and ideas below: The...

Update: Immediately after writing the above comment, I think I realized that I'm thinking about this all wrong. New proposal: - The "current database" selection in the UI should always...

@JamieMagee Thanks for the pointer. This might fit better with `IOptionsMonitor` from that same link, since I'd expect the webhook processor to be a singleton. I'll give that a shot....

Thanks for the suggestion; I've wanted this myself a few times. I've handed this over to the product team to consider for a future update.

If I understand the logs above correctly, you are running `codeql database create`, passing your script as the build command, and your build script invokes the CodeQL `runner.exe`. The CodeQL...