L. David Baron
L. David Baron
I updated `dir-shadow-31-ref.html` per my comment above in 6e02b193e2313fbc1965bcf7371a455459812174. If others want to double-check my work, that would be appreciated, although I think this will make dir-shadow-31.html pass across engines...
So I just looked into the Chromium failure on `dir-shadow-036.html`, which is a test that's closely related to `dir-shadow-006.html` (the main differences being the directionality being the other way around,...
For what it's worth, `dir-shadow-041.html` seems correct to me, although I'm not 100% sure yet. It led me to finding two real Chromium bugs ([fix 1](https://chromium-review.googlesource.com/c/chromium/src/+/4805163), [fix 2](https://chromium-review.googlesource.com/c/chromium/src/+/4805164)), the second...
And I just moved the tests as requested in https://github.com/web-platform-tests/wpt/pull/29820#issuecomment-1692921692 . That triggered a new round of review requests -- though I think we may already have enough reviewers at...
Given the lack of feedback (so far) on https://github.com/web-platform-tests/wpt/pull/29820#issuecomment-1688749979, I updated the expectation for dir-shadow-036.html in 2c55e60c as described in that comment. Still happy to get further feedback, though.
Oh, and another point about dir-shadow-36.html -- it's actually the same test as dir-shadow-38.html except that in the latter the (unrendered) Arabic text inside the slot has a period at...
Status: currently addressed some of @annevk's review comments but not all of them. (And considering writing a bunch of lang tests in JS and dropping this set.) Hopefully will finish...
> I'm not sure I understand the language tests. If they're just about what selectors match, then I'd make them JS tests. I've dropped the language tests (I only added...
FWIW, my work on table layout is mostly not recent, and was back when I worked on Gecko. That said, fixing this to match the WPT results seems reasonable to...
I've been thinking about this issue for a while since @bkardell pointed out this discussion to me, and I suppose I'm still feeling unconvinced. Or, to put it another way,...