daxpedda
daxpedda
From https://github.com/rust-windowing/winit/pull/3056#issuecomment-1695566561: > I will say, I don't think `Exit` has a place in the enum, it's really a separate thing. If you want to have an enum, I think...
Obviously there will always be APIs that should be behind a `cfg` guard because they don't make sense in a cross-platform API, e.g. [`EventLoopBuilder::with_msg_hook()`](https://docs.rs/winit/0.29.1-beta/x86_64-pc-windows-msvc/winit/event_loop/struct.EventLoopBuilder.html#method.with_msg_hook). I agree with the overall sentiment,...
We already have a platform-specific event: [`ActivationTokenDone`](https://docs.rs/winit/0.29.1-beta/winit/event/enum.WindowEvent.html#variant.ActivationTokenDone). This issue isn't for discussing `ControlFlow` specifically, it's for the API to have a consistent way to add platform-specific enum variants. If you...
> @daxpedda it's not if you look into it, it's not marked as wayland/x11 special. What I'm saying is that it is platform-specific, we just didn't mark it as such....
Btw I have proposed a way to avoid `non_exhaustive` in the OP. I honestly dislike slapping `non_exhaustive` on `ControlFlow` way more then on `Event`, I imagine there are extremely few...
> @daxpedda maybe you could explain the extra variant(s) you'd want to add to `ControlFlow`? That'd make it easier for me at least to figure out what the best way...
I didn't look into it, but I was just using SoftHSM. The integration test I've outlined above is using the same setup as in the CI in this repo. I...
> In case my analysis is sound, should this issue be closed? Yes. If indeed SoftHSM is the problem here, then I also do not believe that `cryptoki` should compensate...
Same here, I'm happy to review a PR making the necessary adjustments.
It is indeed [reproducible in the CI](https://github.com/parallaxsecond/rust-cryptoki/actions/runs/14592032848/job/40929291570?pr=263#step:4:474): ``` Running tests/parallel.rs (target/debug/deps/parallel-9574901f18cd4e9f) running 2 tests error: test failed, to rerun pass `-p cryptoki --test parallel` Caused by: process didn't exit successfully:...