Results 765 comments of daxpedda

> On X11 for example there are scroll 'button' inputs, which there aren't any sensible ways to convert into `MouseButton`. Maybe these shouldn't emit a `DeviceEvent::Button` then. Or at least...

> Maybe. I'm coming more from the perspective of `DeviceEvent::Button` being "raw", like just passing what is being received thru the platform APIs directly to the user to allow them...

Just my 2¢: > * Change `GroupDigest` to something like a `Suite` trait. We do actually want generic `ExpandMsg` on a function instead of it being fixed in a associated...

> > We do actually want generic ExpandMsg on a function instead of it being fixed in a associated type. Implementers need this flexibility. Implementing a generic Suite implementer wouldn't...

> > I agree, there should be a suite associates with hash2curve. Its just that users should be able to build their own suite. E.g. combining a custom hash with...

After #1389 I'm not sure what else can be done here. I definitely still want to remove `FromOkm` in favor or `Reduce`. What do you think?

Its not exactly possible to adapt it to this model while keeping all of the current features in this case. The parameter for the existing trait is `I: IntoIterator`, but...

The current trait looks like this: ```rust pub trait MultiscalarMul { type Point; fn multiscalar_alloc_mul(scalars: I, points: J) -> Self::Point where I: IntoIterator, I::Item: Borrow, J: IntoIterator, J::Item: Borrow; }...

> The trait in `elliptic-curve` has an `AsRef` bound on its input which can be used to produce an iterator if desired. `AsRef` produce an `Iterator`? I'm not following, sorry....

> So anything relying on iterating generically can use `AsRef` and `IntoIterator` in combination as a replacement. Ah, I see where the confusion is! I'm talking about the API side,...