Dawson Botsford
Dawson Botsford
Let's wait on this with the first priority now being a full refresh of the landing page. I really like viem.sh and would love your input/shaping of this new website...
This is a good suggestion. You're thinking that the ABI itself would also be encoded fully in the URL? I'm interested @ItsNickBarry if you can make the PR
That's a good spec proposed @startswithaj - If you want to PR this feel free! It should be possible without a breaking change, which is preferred
Hi @KeKs0r , thanks for the PR! Can you provide a test which failed before but succeeds now?
> Checking the other tests, those are quite e2e-ish. So directly against chain. And none of the currently included ABIs have those fields. Should I just add a new ABI...
Hey @KeKs0r I forgot to follow-up here. Was there anything more you needed to get unblocked writing those tests? Thanks for the PR 🙏
> Checking the other tests, those are quite e2e-ish. So directly against chain. And none of the currently included ABIs have those fields. Should I just add a new ABI...
I think we're almost ready to solve this. We can make a test which validates we match `encodeFunctionData` from ethers: https://docs.ethers.org/v5/api/utils/abi/interface/#Interface--encoding We currently have this logic all crammed into the...
@joshuakings231 you'll have to do separate transactions for now, but this should work yes. Please try and let me know!
I'm not sure if this would damage performance for as-many files as one might have showing in the results. I'm open to seeing a PR if you want to try,...