Xiaoming Wang
Xiaoming Wang
Try to run the `gh-pages` branch, and discover it hasn't been updated for a year, and the original `gh-pages` branch has already been broken for more than a year. probablly...
After some investigation in the `gh-pages` branch, in order to make latest @ledgerhq library work, we need to get rid of `browserify` library (used to enable `require(module)` in browser), but...
Unable to get the error log like above in `main` branch, please make sure this still happening in latest code.
hi, the issue was caused by PreferenceController and AccountController state(regarding the account name) is difference. and this PR @owencraston create should be able to fix the issue https://github.com/MetaMask/metamask-mobile/pull/9724 once above...
hi, @xardass the PR has been approved by two code reviewer and has `qa passed` tag. so you can `Squash and merge` the PR now.
> Lint failing This have been resolved.
Final e2e tests are all green even `Bitrise E2E Status` display failure. https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c6b59eaa-aacd-4177-acbb-acac8342db20
> LGTM! I just left one final comment that was not resolved yet in the previous reviews hi, @gantunesr i have done the change to `AccountSelector` component to make `onCheck`...
Final `e2e` tests has passed https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/942d85f4-ec3c-4bab-936f-333db0f572cd
E2e smoke tests pass. https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/92c7ec10-e428-40d5-b64c-41cc42c0c577