Dawid Wysakowicz

Results 24 comments of Dawid Wysakowicz

Before I review the code let's settle on the behaviour first. @MartijnVisser What is your opinion on how the function should behave? Especially in the context of https://github.com/apache/flink/pull/23173#discussion_r1491044219 and handling...

> Also for EMPTY OBJECT That's expected. I will adjust the type inference logic to fail earlier.

> SELECT JSON_QUERY('{"a":[{"c":null},{"c":"c2"}]}', 'lax $.a[*].c' RETURNING ARRAY); > SELECT JSON_QUERY('{"a":[{"c":null},{"c":"c2"}]}', 'lax $.a[*].c' RETURNING ARRAY ERROR ON ERROR); Good catch on that. Just a comment: > SELECT JSON_QUERY('{"a":[{"c":null},{"c":"c2"}]}', 'lax $.a[*].c' RETURNING...

I believe this falls into `ON EMPTY` category and the default is `NULL`. If you use `lax` strategy the checks are less strict and there is no error, but no...