Dawid Wysakowicz

Hey @liuyongvs I am sorry for the situation we ended up here. You're right we should've checked with you. I admit I have not been careful enough here. Please accept...

> If the delimiter is empty, every character in the string is split Is that a requirement? As far as I can tell ksqlDB is the only engine that has...

> Now we use splitByWholeSeparatorPreserveAllTokens, when delimiter is empty, it will return entire string. Actually it splits by whitespaces: https://github.com/apache/flink/blob/8e5220b288e49c99333a4bc8ef7e3d5d27193921/flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/data/binary/BinaryStringDataUtil.java#L107 > I think we can change the description, Let's first...

@MartijnVisser To confirm, you suggest to support an empty delimiter and in that case split all characters, meaning: ``` SPLIT('abcde', '') = ['a', 'b', 'c', 'd', 'e'] SPLIT('It is', '')=['I',...

> When the delimiter is empty, do we need to handle this situation specially?/ Yes, we do. Do you mind updating the PR?

@mihaibudiu I extended the PR with runtime evaluation

> When you respond to comments you should not force-push, but rather add new commits, to make it easier to review what's new. Sorry about that. I usually do that...

> What does this do when you try to return a value which has an incorrect type, e.g., you return an integer, but the value is an array? That is...

I was not verbose enough on the JIRA description. I am interested in supporting only part of the entire standard : `RETURNING ` without the `FORMAT ...` part (similarly to...

Thank you both for the reviews @snuyanzin @mihaibudiu