Dave Lucia

Results 78 comments of Dave Lucia

Also see https://github.com/beam-community/avro_ex/pull/80#issuecomment-1207836026

Thank you for the PR! I will provide some direct feedback this week. One immediate piece of feedback is to move all codecs to separate files

Took a quick look at this, here is some general feedback: 1. To keep the API surface area of `AvroEx` as small as possible, I would suggest that we have...

hello @veedo, just wanted to check in on this PR, are you waiting on any review from me, or still a WIP?

No rush! Just wanted to make sure you weren't waiting on me

I would highly recommend taking the approach that Marlus took for [Surface's init and convert tools](https://github.com/surface-ui/surface/blob/main/lib/mix/tasks/surface/surface.init.ex), which makes use of [sourceror](https://github.com/doorgan/sourceror) for making code modifications.

I have limited time, but I'm definitely interested in helping!

I've been chatting with Marlus and others on the use of Sourceror for applying patches. Relevant issue https://github.com/doorgan/sourceror/issues/64