avro_ex icon indicating copy to clipboard operation
avro_ex copied to clipboard

default values of `null` are removed from schema in `encode_schema`

Open otosky opened this issue 3 years ago • 2 comments
trafficstars

Heyo 👋

Ran into an edge case today where a schema defined in JSON containing nullable unions would have the "default": null portion stripped out if it was run through a sequence of AvroEx.decode_schema -> AvroEx.encode_schema.

Example:

schema = AvroEx.decode_schema!(~S({
  "type": "record", 
  "name": "Record", 
  "fields": [
     {"type": ["null", "int"], "name": "nullable", "default": null}
   ]
}))
AvroEx.encode_schema(schema)

Output:

"{\"fields\":[{\"name\":\"nullable\",\"type\":[{\"type\":\"null\"},{\"type\":\"int\"}]}],\"name\":\"Record\",\"type\":\"record\"}"

I haven't dug too deep, but other primitives seem okay:

schema = AvroEx.decode_schema!(~S({
  "type": "record", 
  "name": "Record", 
  "fields": [
     {"type": ["null", "int"], "name": "nullable", "default": 5}
   ]
}))
AvroEx.encode_schema(schema)
"{\"fields\":[{\"default\":5,\"name\":\"nullable\",\"type\":[{\"type\":\"null\"},{\"type\":\"int\"}]}],\"name\":\"Record\",\"type\":\"record\"}"

Using v2.0.1

otosky avatar Jun 23 '22 01:06 otosky

Thanks for the report @otosky :)

davydog187 avatar Jun 23 '22 15:06 davydog187

@marpo60 told me he is working on a fix

davydog187 avatar Jun 23 '22 16:06 davydog187