James C. (Jamie) Davis
James C. (Jamie) Davis
I don't think the HTTP approach is all that scary. How to extend the various components to support various reporting/response mechanisms is the bigger question. @mauricioaniche Can you advise on...
Looking through here, I'm a bit confused about why Modification doesn't make use of the various Diff classes. It would make more sense to me if a Modification returned your...
Yes, that's what I had in mind. If a Modification can return something semantically relevant instead of a raw diff, then the caller can easily extract the added and removed...
@mauricioaniche This would be a breaking change. Thoughts?
@ayaankazerouni Did you do anything for this?
1. "The idea of the ChangeSet class was for it to be a lightweight way to get all commit hashes that need to be investigated later. I think we can...
1. "As we don't have filter based on commit messages, I suggest we do not store them in ChangeSet." I've seen some research studies that do filter based on commit...
4b88f68 addresses the second suggestion. I've kept the commit messages for now. I don't think it makes sense to worry about the storage overhead of messages -- do you have...
6ba0cf8 means that existing ChangeSet filters won't break, though I've marked `ChangeSet.getTime` deprecated.
It seems like the question is how much it costs to extract a full Commit, and what the user might want to filter on. Here are my thoughts: My guess...