James C. (Jamie) Davis
James C. (Jamie) Davis
@mauricioaniche Can you clarify when to put functionality into the `SCM` interface vs. the `SCMRepository` class?
There is some relevant discussion in #62.
Agreed, seems like a good fit. Some clarity on the relationship between Diffs, Modifications, Commits, etc. in the Javadoc would also be helpful.
The goal is to return the diff between commit A and commit B, yes. This can be done either by: 1. Returning the sequence of commits between A and B....
Modification or DiffEntry is fine, I'm not sure of the difference yet. Not a String though, per #62: why provide a String when we have better options?
Ah, that's why I couldn't find `DiffEntry` in the RepoDriller source -- it's from JGit! If the proposed `getDiffBetween(X, Y)` is in `SCM` then it certainly shouldn't be returning a...
LGTM. Nice job.
I think we could do this readily in `RepositoryMining`. 1. "Finish processing the current repo" 2. "Finish processing the current commit" Implementation options: 1. Make `mine` asynchronous and add methods...
I'm a bit confused about your environment variable idea. I thought that once a process A has begun, another process B cannot (easily) change A's environment variables. SO seems to...
# Design The overall design is independent of mechanism: - Some background thread listens for requests - It "does something" - It sends a response back Requests might be "what...