davinlagerroos

We build a view that returned the information from the database link and used that view as our active record source. The downside is we have to maintain the link...

Thanks for your comment on this issue. Once we figured out what was going on, we did the work around you suggested. We stopped creating the synonyms and switched to...

First, thanks @andynu for the work you've put in to upgrading this library! Second, I am by no means an expert in this library or its patterns. My group uses...

Something to consider: it appears oracle-enhanced has a [practice of overriding these kinds of defaults](https://github.com/rsim/oracle-enhanced/blob/750004962c356f9e481418664806f538b364621f/lib/active_record/connection_adapters/oracle_enhanced_adapter.rb#L692-L696). [Following that pattern](https://github.com/umn-asr/oracle-enhanced/commit/fa4a460b56d0eeae53aae298e7558bcc9743b1a0) still gets `spec/active_record/connection_adapters/oracle_enhanced/schema_statements_spec.rb:330` to pass and avoids the possibility of causing upgrade...

Thanks for considering my suggestion! I think approach of aliasing the method still works with oracle 11. The method that would be aliased, [max_identifier_length](https://github.com/rsim/oracle-enhanced/blob/750004962c356f9e481418664806f538b364621f/lib/active_record/connection_adapters/oracle_enhanced_adapter.rb#L692-L696) calls [suports_long_identifier?](https://github.com/rsim/oracle-enhanced/blob/750004962c356f9e481418664806f538b364621f/lib/active_record/connection_adapters/oracle_enhanced_adapter.rb#L361-L367) which includes an oracle...

@andynu My bad, I missed the test output! Thanks for making it more obvious. That is definitely not a good outcome. hmm, when [index_name calls `super`](https://github.com/rsim/oracle-enhanced/blob/750004962c356f9e481418664806f538b364621f/lib/active_record/connection_adapters/oracle_enhanced/schema_statements.rb#L343), activerecord uses the [max_index_name_size...

@andynu Thanks for trying that out! I am glad it worked

Something to consider: you can also define an adapter-specific `valid_column_definition_options` that calls `super` and adds the db-specific extras, e.g. https://github.com/umn-asr/oracle-enhanced/commit/211e3d164ac94fbdd4d165c4e7e16a96922b581e. This is closer to the pattern that the reference implementations...

I'm glad that is helpful. Thanks for considering it! I also wanted to add that I really like your general approach of slowly bumping the rails version with each PR...