Denis Davidyuk

Results 183 comments of Denis Davidyuk

On the wallet side the quotes are explicitly removed before tip sending in https://github.com/aeternity/superhero-wallet/blob/8bce63c8f0d7affcb9297bf874e1d0846a97bd69/src/popup/router/pages/Tip.vue#L237 https://github.com/aeternity/superhero-wallet/blob/8bce63c8f0d7affcb9297bf874e1d0846a97bd69/src/popup/utils/helper.js#L219-L220 Git blame doesn't say anything meaningful 🤷‍♀️: https://github.com/aeternity/superhero-wallet/commit/8d3766b85932b69b7460349340bd79ce6a1fe112

It looks like you are connected to different networks in the wallet and in your app: ```bash $ curl https://testnet.aeternity.io/v2/accounts/ak_2TKYxRRUdwCH2jFX9go6Se4GVbKUFvyGn4r6mVS1CbrQJ6DWds { "balance":5000000000000000000, "id":"ak_2TKYxRRUdwCH2jFX9go6Se4GVbKUFvyGn4r6mVS1CbrQJ6DWds", "kind":"basic", "nonce":0, "payable":true } $ curl https://mainnet.aeternity.io/v2/accounts/ak_2TKYxRRUdwCH2jFX9go6Se4GVbKUFvyGn4r6mVS1CbrQJ6DWds...

I propose to set `canvas` version range to `^2.11.2 || ^3.0.0` https://github.com/kozakdenys/qr-code-styling/blob/43d41710221204858ccbd5b5065ec41d23b50544/package.json#L20 The only breaking change [they did](https://github.com/Automattic/node-canvas/releases/tag/v3.0.0) is dropping node@16, so this package should be compatible with the new...

related bug on Superhero Wallet side: https://github.com/superhero-com/superhero-wallet/issues/3509 another necessary fix: https://github.com/aeternity/aepp-sdk-js/pull/2050 After resolving the above, I expect this will work out of the box. Meanwhile, you need to manually detect...

Looks like an issue on Sophia side, AENS pointers are actually defined this way, probably there was a reason to do so.

Also, can this polling part be moved to the sdk side?

Should interval be decreased to something like 1 second to speedup wallet detection?

> you have full control over this Have you tried to find the best decision? It looks like a controversial issue caused by a wrong architectural decision on the sdk...

I want to notice that the wallet team considered default behavior as a bug and has switched to infinite pooling. I'm proposing to update the sdk examples accordingly.