Denis Davidyuk

Results 183 comments of Denis Davidyuk

This would work if you pass `connectNode` option to `connectToWallet` https://github.com/nikita-fuchs/nftminter/blob/2e5c0580618dda710ae2bd097e6fc38f6a140501/src/app/services/aeternity.service.ts#L98 https://docs.aeternity.com/aepp-sdk-js/v12.1.3/api/classes/AeSdkAepp.html#connectToWallet

This is how it is implemented now, proxying requests through wallet a bit more difficult to implement, but we will consider this

Instead of returning transactions unpacked on node side would be better to unpack transactions on sdk side https://github.com/aeternity/aeternity/issues/4085

> does it make sense to do tackle this before we remove stamps and introduce typescript? Nope > what's your opinion about that? would you like to see mdw endpoints...

I'm planning to do a minor improvement here: `onSign` callback in `AeSdkWallet` should be removed and `signTransaction` method of Account used instead. The reason is that in case we using...

Not really, it can just communicate to node directly 🙃

As I know, the problem is that when the wallet connects to it's content script it considers to be connected to app even if aepp doesn't talk to content script....

Actually, it is not necessary to remove extra rpc clients, because it can be detected is aepp connected or not by `_isRpcClientConnected` (but need to make it public somehow).

> I guess we wouldn't be able to make use of this stuff during runtime, right? Yep > wouldn't that be a logic that could (and maybe should) be integrated...