David Wood
David Wood
@Mark-Simulacrum this is ready to be reviewed and approved now that the FCP has finished
I haven't thoroughly reviewed the changes here but this seems sensible to me at first glance.
> > For macros from other crates the spans are still collapsed to a single call site span, this way we don't jump to code of println! and other macros...
> * What happens to the current groups? Are all current contributors going to become team members? Are all current team members going to become FCP reviewers? Contributors would become...
I've also renamed "responsibilities" to "maintenance activities". I was never happy with "responsibilities" as the term and I think maintenance activities is better, but can change back if there is...
> What would they look like? Will there be a single place where I can see which people are signed up for which maintenance tasks? How will alumni be recorded?...
> Is it worth distinguishing FCPs like _this_ (i.e. FCPs about the team itself) from "typical" FCPs in regards to who is involved? I've added a little bit of wording...
> The tests in [`diagnostics.rs`](https://github.com/rust-lang/rust/blob/534ddc6166a9031b0c269544929d68f2539ea7a0/src/test/ui-fulldeps/internal-lints/diagnostics.rs) only cover `Diagnostic` and the `err` functions, but not `LintDiagnostic` and the `lint` functions. @Rejyr I think that's mostly okay though - it tests that...