David Clark

Results 147 comments of David Clark

It's a little bit odd because it starts with a Browserify bundle: ``` js function bundleApp(b, cb) { cb = cb || _.noop; return b.bundle() .on('error', function(err) { console.error(err); })...

Ok, so that's not a situation that's already been taken into account. If I have the chance I'll try to look into it. And of course if you @lazd or...

I was hoping there would be some built-in Gulp way to make sourcemaps like magic, but I don't think there is, right? `gulp-sourcemaps` basically says that each plugin is responsible...

I agree with the above opinions that this plugin could leave SVGO out and pass off the optimization task to the user. I find that that kind of separation of...

I suspect that this is because the modal's focus-trap is preventing you from shifting focus to the dropdown (via click). Probably Kendo is rendering the dropdown in a node *outside*...

I'd suggest not making it a button. The Tab already has all the event handlers and ARIA attributes that it needs. A button probably confuses that in at least a...

Hi @ericedem. As you suggest, tracking the mouse sounds pretty unreliable. I'd be interested in hearing any other ideas for solving this!

One relatively simple solution that might work is to add an `underlayClickExitsExeceptions` prop, which takes an array of strings, each of which is a selector; and if the selector matches...

@conanm: Try setting the prop `scrollDisabled={false}`. Does that make a difference? If so, the bug is related to the dependency no-scroll: https://github.com/davidtheclark/no-scroll

Open to a PR. I agree that that would be ideal; however, the current code does not allow it because of the significant complexities it introduces. I remember thinking about...