David Clark

Results 147 comments of David Clark

I agree that this would be very useful. Using rehype to parse HTML and look for matching headings seems reasonable to me, and `check-links` seems like the place to do...

Is postcss-nested running before or after extend? I _think_ (not sure) you'll to run it before, so that the selectors are modified by postcss-nested and then extended with this plugin....

Oh yeah, sorry -- wasn't thinking clearly. That shouldn't work. And at this point I don't think I'm going to complexify this particular plugin to allow for that syntax. You...

The nesting resolution should be relegated to a plugin like [postcss-nested](https://github.com/postcss/postcss-nested). But I'm open to a PR making changes that ensure it works this way with postcss-nested.

I *think* the only reason for this is that it hasn't been implemented yet. Over in the dependency focus-group, I limited the keyboard listeners to letter keys: https://github.com/davidtheclark/focus-group/blob/b9de0536aa9b065b110a3880650f83e925ceef13/index.js#L133-L134 I wanted...

Same crashing here.

> What do you mean? I'm just trying to understand the use case here because it's not obvious to me. How do you hit escape outside the modal — did...

Ah, weird. I think it might be perfectly fine to attach the escape listener to the underlay [instead of the document](https://github.com/davidtheclark/react-aria-modal/blob/7b2ad97858bbfad93e486f176341ce556bd8c9a4/src/react-aria-modal.js#L41). That should solve things for you, right?