David Hewitt

Results 200 comments of David Hewitt

Yep, I've found that the light-locker code doesn't really account for a lid closed with external monitor situation. It works if you start the laptop up with the lid closed...

The more I work with light-locker, the more I realise its the cause of quite a few issues. The other issue is that it doesn't really have any active maintainers...

Hm, interesting, although that wouldn't be that easy to implement in itself. And I'm not sure what horrible things would happen if light-locker was killed/restarted while the machine was locked....

Quick update, I've opened a PR against gala that implements the potential replacement for `light-locker`: https://github.com/elementary/gala/pull/809 If you're interested in some super early testing of that, then there are some...

@ryonakano Can you update this issue with the current status of where we're up to on this?

I spotted code that's supposed to handle this already: https://github.com/elementary/appcenter/blob/9165da251bcde7963c6b0895ffcf005d5bf5627f/src/Application.vala#L152-L154 Do we know for sure it doesn't already work?

Yes, the code changes required to resolve this issue would be made in this repository. Generally, issues are reported against the GitHub repository where the relevant code lives. And if...

There's also some good general docs about contributing here: https://docs.elementary.io/contributor-guide

I've swapped this dependency and tested events are still being sent to sentry. No longer required.

That's very cool, I like that idea a lot! It's a little slow since it's running in the browser under JavaScript, but definitely way less of a technical barrier. I...