David I. Lehn

Results 315 comments of David I. Lehn

@alantrick The tests have many failures now because the test suite and specs moved forward and the code hasn't caught up. Unless someone jumps in on this the code likely...

I doubt this feature has been tested. Sorry about that. The test suites need updates to check these newer features. The code was probably ported from jsonld.js long ago. Might...

Tests over here: https://github.com/w3c/json-ld-api/pull/490 It's failing at some low level with new basic tests. Haven't debugged yet, but looks like scoped contexts are just overwriting top level contexts?

Bisect for basic additive scoped context fails here: - https://github.com/digitalbazaar/jsonld.js/commit/84b77681d3666cf804e581574f406280ce7bd88b

In the code that does processing just to validate, I think the bug can be fixed with `activeCtx: rval.clone()` instead of just `rval`. That seems an unfortunate efficiency issue. Is...

The proposed patch was added to jsonld.js 3.2.0 and is live on playground now. I think this issue is fixed. Please test. There is the possibility of a performance regression...

Also note IDL changes here: https://github.com/w3c/json-ld-api/pull/500 @gkellogg Do you know what changes are required due to the above? Should this lib still be using "JsonLdProcessor"? I'm not sure how the...

See https://github.com/digitalbazaar/jsonld.js/pull/347.

The Makefile will be gone. Will have to check new commands for portability. I'm guessing things like `${REPORTER:-spec}` that are sh specific might have issues. So cross-env or a minor...

The code has changed quite a bit. This patch needs to be updated if it's still an issue.