jsonld.js icon indicating copy to clipboard operation
jsonld.js copied to clipboard

Use npm-run-scripts for commandline tooling

Open BigBlueHat opened this issue 8 years ago • 6 comments

Useful for Windows development (hence the new cross-env dependency).

Makefile is still there in case deploy/host scripts depend on it...though it could in turn use the npm run scripts.

The commands match the Makefile commands, so:

$ make test-node
$ # is the same as
$ npm run test-node

Let me know if it needs tweaks!

BigBlueHat avatar Feb 13 '17 21:02 BigBlueHat

Also, I should note that I've tested this in the Windows Linux Sub-System (lxss; aka "ubuntu in windows"), MingW, and PowerShell.

BigBlueHat avatar Feb 13 '17 21:02 BigBlueHat

Found and fixed a path issue when running in bash (mingw) in Windows. Should be good to go (completely) in all those scenarios now.

BigBlueHat avatar Feb 14 '17 18:02 BigBlueHat

Just an idea: Makefile will be just a way to run NPM scripts, so it could be replaced by fakefile

adambro avatar Aug 09 '17 10:08 adambro

I would like to close this out, I think #194 will supersede everything here -- so we shouldn't put any more effort into this PR. @davidlehn can you confirm?

dlongley avatar Aug 09 '17 13:08 dlongley

The Makefile will be gone. Will have to check new commands for portability. I'm guessing things like ${REPORTER:-spec} that are sh specific might have issues. So cross-env or a minor rework might be needed. It's just nice to be able to do REPORTER=nyan npm t when the need arises.

davidlehn avatar Aug 09 '17 15:08 davidlehn

The code has changed quite a bit. This patch needs to be updated if it's still an issue.

davidlehn avatar Jan 25 '18 23:01 davidlehn