David Lai

Results 196 comments of David Lai

Link this to #27 . Drop Python 2 support in next minor release.

Since #28 is on going, maybe we should start this after #28 is merged so to avoid merging conflicts. But I am not sure when I am able to back...

Hi @sousajf1 , sure. :) I am not sure when I can finish #28 so yeah, we should star this one. Happy to see improvements!

> so supported python versions 3.7-3.9 ? Should be 3.6-3.9, which are versions being tested in Github Actions.

Ouch, I was referencing that info from README ! 🤕 Hmmm, Python 3.6 should be supported, it was in the [Azure test](https://github.com/davidlatwe/montydb/blob/82f0c0c8e7e647ccc51ab59ac65e6bc18f426020/azure-pipelines.yml#L47-L50) before I change to use GitHub Action not...

> Could you add it back to the workflow ? Hey @madeinoz67 sorry, never mind, just created #59 to see if Python 3.6 still pass the tests.

Yeah, that's right! 😄

Looks like it's because of the PyQt5 version you are using, it's `5.13.1`. Could you run a test with version `5.9` ?

I had seen this issue while I was working on PR #354 with latest `PySide2`, and resolved it in commit ae04b48. Maybe it will resolved this, too. (Using `PyQt5==5.13.1`)

> Nevertheless, it feels a bit odd that it would solely be a thing for Pyblish QML and their being no API equivalent to this feature in pyblish-base - so...